lkml.org 
[lkml]   [2008]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/7] PPS: serial clients support.
On Fri, Mar 21, 2008 at 10:41:25AM -0700, Andrew Morton wrote:
> On Fri, 21 Mar 2008 12:17:36 +0100 Rodolfo Giometti <giometti@enneenne.com> wrote:
>
> > > > +#else
> > > > +
> > > > +#define uart_register_pps_port(state, port) do { } while (0)
> > > > +#define uart_unregister_pps_port(state, port) do { } while (0)
> > >
> > > Please never implement in cpp that which can be implemented in C. These
> > > should have been static inlines. That's nicer, matches the
> > > CONFIG_PPS_CLIENT_UART=y code and provides type checking.
> >
> > Are you saying that I should do:
> >
> > static inline int
> > uart_register_pps_port(struct uart_state *state, struct uart_port *port)
> > {
> > /* Nop */
> > }
> >
> > static inline void
> > uart_unregister_pps_port(struct uart_state *state, struct uart_port *port)
> > {
> > /* Nop */
> > }
> >
> > ?
>
> Yes please.

Fixed. I'll send a new patch ASAP.

Rodolfo

--

GNU/Linux Solutions e-mail: giometti@enneenne.com
Linux Device Driver giometti@gnudd.com
Embedded Systems giometti@linux.it
UNIX programming phone: +39 349 2432127


\
 
 \ /
  Last update: 2008-03-25 11:41    [W:0.050 / U:2.728 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site