Messages in this thread | | | Date | Thu, 28 Feb 2008 11:50:00 -0500 | From | Jason Baron <> | Subject | Re: [patch 1/7] Immediate Values - Architecture Independent Code |
| |
On Wed, Feb 27, 2008 at 02:05:19PM -0500, Mathieu Desnoyers wrote: > > +struct stop_machine_data { > > + int (*fn)(void *); > > + void *data; > > + struct completion done; > > + int run_all; > > +} smdata; > > + > > Why do we now have to declare this static ? Can we pass it as a pointer > to stopmachine instead ? >
Since the other cpus need to access 'fn', i made smdata a global. stop_machine_run() is system-wide, so we only need one of these...
thanks,
-Jason
| |