lkml.org 
[lkml]   [2008]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC] mmiotrace full patch, preview 1
On Mon, Feb 25, 2008 at 09:42:00PM -0500, Pavel Roskin wrote:
> It looks like a mutex, it acts like a mutex, but it isn't a mutex, it's a
> trap for the unwary. Weird. I was annoyed by it before; now I see a
> fellow developer actually getting into that trap.
>
> I'd say, rename DECLARE_MUTEX to DECLARE_SEMAPHORE and let external code be
> fixed one way or another (i.e. stick with the "mutex" name or stick with
> the semaphore functionality if it's really needed).

It's a semaphore used as mutex. Until we got struct mutex this was
perfectly fine and now we're phasing it out and will hopefully get rid
of it soon. It just takes some time to convert all users.



\
 
 \ /
  Last update: 2008-02-26 18:13    [W:0.049 / U:1.772 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site