lkml.org 
[lkml]   [2008]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC] mmiotrace full patch, preview 1

* Andy Whitcroft <apw@shadowen.org> wrote:

> Ok, so that would be the following, work for everyone?
>
> WARNING: mutexes are preferred for single holder semaphores
> #1: FILE: Z95.c:1:
> + DECLARE_MUTEX(&foo);
>
> WARNING: mutexes are preferred for single holder semaphores
> #3: FILE: Z95.c:3:
> + init_MUTEX(&foo);

yeah.

Acked-by: Ingo Molnar <mingo@elte.hu>

also i guess init_MUTEX_LOCKED() should emit a "this should be a
completion" warning.

i guess non-DEFINE_SPINLOCK old-style spinlock definition:

spinlock_t lock = SPIN_LOCK_UNLOCKED;

should emit a 'use DEFINE_SPINLOCK' warning as well?

Ingo


\
 
 \ /
  Last update: 2008-02-26 11:53    [W:0.046 / U:1.448 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site