Messages in this thread | | | Date | Sun, 24 Feb 2008 10:00:18 -0800 | From | Greg KH <> | Subject | Re: [RFC 01/11] add generic versions of debugfs file operations |
| |
On Sun, Feb 24, 2008 at 11:46:07AM +0100, Arnd Bergmann wrote: > On Saturday 23 February 2008, Al Viro wrote: > > > Ewww - caps, \n... BTW, \0 is pointless here - simple_read_from_buffer() will > > not access it with these arguments)... > > > ... > > > Please, check the length; sloppy input grammar is a bad idea. Hell, at the > > very least you want -EINVAL if input is not recognized... > > Ok, these two come straight from debugfs, but of course I can fix them > anyway. Should I do a fix for debugfs in 2.6.25 first, or rather do a > patch on top of the libfs rework?
I'll gladly take a patch to debugfs for it :)
thanks,
greg k-h
| |