Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [RFC 01/11] add generic versions of debugfs file operations | Date | Sun, 24 Feb 2008 11:46:07 +0100 |
| |
On Saturday 23 February 2008, Al Viro wrote:
> Ewww - caps, \n... BTW, \0 is pointless here - simple_read_from_buffer() will > not access it with these arguments)...
> ...
> Please, check the length; sloppy input grammar is a bad idea. Hell, at the > very least you want -EINVAL if input is not recognized...
Ok, these two come straight from debugfs, but of course I can fix them anyway. Should I do a fix for debugfs in 2.6.25 first, or rather do a patch on top of the libfs rework?
I'd rather not have any semantic changes during the conversion, so it would be better to keep that separate imho.
Arnd <><
| |