lkml.org 
[lkml]   [2008]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RFC 01/11] add generic versions of debugfs file operations
Date
On Saturday 23 February 2008, Al Viro wrote:

> Ewww - caps, \n... BTW, \0 is pointless here - simple_read_from_buffer() will
> not access it with these arguments)...

> ...

> Please, check the length; sloppy input grammar is a bad idea. Hell, at the
> very least you want -EINVAL if input is not recognized...

Ok, these two come straight from debugfs, but of course I can fix them
anyway. Should I do a fix for debugfs in 2.6.25 first, or rather do a
patch on top of the libfs rework?

I'd rather not have any semantic changes during the conversion, so
it would be better to keep that separate imho.

Arnd <><


\
 
 \ /
  Last update: 2008-02-24 11:49    [W:0.315 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site