Messages in this thread | | | Date | Sat, 23 Feb 2008 11:16:29 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH 00/16] (Resend) Use get_personality() |
| |
On Sat, 23 Feb 2008 13:37:31 -0500 Christoph Hellwig <hch@infradead.org> wrote:
> On Sat, Feb 23, 2008 at 12:27:10PM +0300, Alexey Dobriyan wrote: > > > Use get_personality() can hide the task_struct internals a bit. > > > > ->personality is going to become something less trivial? > > Sorry, but you sound like C++ people writing tons of pointless get/set > > wrappers. And your get_personality() is worse -- C++ would write it as > > > > current->personality() > > > > and again, even here, it's immediately visible that current task is > > involved, not some other task. > > Yes, completely agreement. While I might have introduced this gem > back then it is entirely stupid if you think about it. Please send > patches to kill get_personality and just use current->personality > instead. >
yup.
We'll generally only add wrappers of this form if we need to provide alternative implementations, or if we expect that we shall do so in the future.
| |