Messages in this thread | | | Date | Sat, 23 Feb 2008 12:27:10 +0300 | Subject | Re: [PATCH 00/16] (Resend) Use get_personality() | From | Alexey Dobriyan <> |
| |
On Sat, Feb 23, 2008 at 04:59:44PM +0800, WANG Cong wrote: > From: Alexey Dobriyan <adobriyan@gmail.com> > Subject: Re: [PATCH 00/16] (Resend) Use get_personality()
> > On Sat, Feb 23, 2008 at 04:14:03PM +0800, WANG Cong wrote: > > > This patchset makes the macro get_personality function alike > > > and teaches code to use get_personality() instead of explicit > > > reference. > > > > > > [I am sorry if you've received multiple copied of this, since > > > my git-send-email doesn't work well. ] > > > > Yes, but why? "current->personality" is way more understandable than > > your macro because task subject to dereference is very visible. > > Use get_personality() can hide the task_struct internals a bit.
->personality is going to become something less trivial? Sorry, but you sound like C++ people writing tons of pointless get/set wrappers. And your get_personality() is worse -- C++ would write it as
current->personality()
and again, even here, it's immediately visible that current task is involved, not some other task.
> And I don't think using the macro to access it is less understandable. > Since 'current' won't be NULL, whether the dereference is visible is > not important.
It's not about NULL vs non-NULL at all.
| |