Messages in this thread | | | Date | Fri, 22 Feb 2008 10:10:16 +0000 | From | Alan Cox <> | Subject | Re: usb/serial/io_ti.c: inconsequent NULL checking |
| |
> Either the test of port->tty here is unneeded: > > if (port->tty) > port->tty->low_latency = low_latency; > > ...or the lack of test of port->tty here is a mistake: > > edge_set_termios (port, port->tty->termios);
Interesting - so coverity doesn't understand the BKL. It's producing the right answer, for the right reason but the assumption it makes isn't 100% safe.
The check can go.
Alan
| |