lkml.org 
[lkml]   [2008]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: usb/serial/io_ti.c: inconsequent NULL checking
> Either the test of port->tty here is unneeded:
>
> if (port->tty)
> port->tty->low_latency = low_latency;
>
> ...or the lack of test of port->tty here is a mistake:
>
> edge_set_termios (port, port->tty->termios);

Interesting - so coverity doesn't understand the BKL. It's producing the
right answer, for the right reason but the assumption it makes isn't 100%
safe.

The check can go.

Alan



\
 
 \ /
  Last update: 2008-02-22 11:23    [W:0.038 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site