Messages in this thread | | | Date | Tue, 19 Feb 2008 15:38:58 -0800 | From | "Ray Lee" <> | Subject | Re: usb/serial/io_ti.c: inconsequent NULL checking |
| |
On Feb 19, 2008 3:25 PM, Greg KH <gregkh@suse.de> wrote: > On Wed, Feb 20, 2008 at 12:49:15AM +0200, Adrian Bunk wrote: > > The Coverity checker spotted the following inconsequent NULL checking > > introduced by commit d5f5bcd425b771c0b7ff5a650b2ce061ac8bbb87: > > > > <-- snip --> > > It's not a real problem, that pointer can't go away.
I think he meant inconsistent not "inconsequent."
Either the test of port->tty here is unneeded:
if (port->tty) port->tty->low_latency = low_latency;
...or the lack of test of port->tty here is a mistake:
edge_set_termios (port, port->tty->termios);
| |