Messages in this thread | | | Date | Fri, 22 Feb 2008 17:12:56 +0100 | From | Sam Ravnborg <> | Subject | Re: Regression [Was: Boot hang with stack protector on x86_64] |
| |
On Fri, Feb 22, 2008 at 07:43:08AM -0800, Linus Torvalds wrote: > > > On Fri, 22 Feb 2008, Sam Ravnborg wrote: > > > > This is a regression. Can you please revert this commit. > > Not really. The thing is, CONFIG_CC_STACKPROTECTOR has never done anything > at all, now it does, and it shows that it never worked. And this made a machine non-bootable that could boot before.
> > So the commit that made it do something shouldn't be reverted, but > CONFIG_CC_STACKPROTECTOR should be marked BROKEN, because it obviously is > broken right now. > > But keeping the config option, and just not making it do anything is > misleading and wrong. > > So just something like this? To make sure normal people don't enable it.. Whatever is fine with me - I hope Ingo & Co fixes the root cause soon so we can get the right fix in.
Sam
| |