Messages in this thread Patch in this message | | | Date | Fri, 22 Feb 2008 07:43:08 -0800 (PST) | From | Linus Torvalds <> | Subject | Re: Regression [Was: Boot hang with stack protector on x86_64] |
| |
On Fri, 22 Feb 2008, Sam Ravnborg wrote: > > This is a regression. Can you please revert this commit.
Not really. The thing is, CONFIG_CC_STACKPROTECTOR has never done anything at all, now it does, and it shows that it never worked.
So the commit that made it do something shouldn't be reverted, but CONFIG_CC_STACKPROTECTOR should be marked BROKEN, because it obviously is broken right now.
But keeping the config option, and just not making it do anything is misleading and wrong.
So just something like this? To make sure normal people don't enable it..
Linus
--- arch/x86/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 3be2305..4a88cf7 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -1054,7 +1054,7 @@ config SECCOMP config CC_STACKPROTECTOR bool "Enable -fstack-protector buffer overflow detection (EXPERIMENTAL)" - depends on X86_64 && EXPERIMENTAL + depends on X86_64 && EXPERIMENTAL && BROKEN help This option turns on the -fstack-protector GCC feature. This feature puts, at the beginning of critical functions, a canary
| |