Messages in this thread | | | Date | Mon, 18 Feb 2008 18:02:36 +0100 | From | "Bartlomiej Zolnierkiewicz" <> | Subject | Re: [PATCH 1/5] ide: remove PIO "downgrade" quirk |
| |
Hi Sergei,
On Feb 18, 2008 5:06 PM, Sergei Shtylyov <sshtylyov@ru.mvista.com> wrote: > Bartlomiej Zolnierkiewicz wrote: > > > No need for it nowadays > > Since which moment, could you elaborate
We fixed:
- PIO auto-tuning in core code
- PIO programming in host drivers
- IORDY handling in core code and in host drivers (it could be that the incorrect IORDY handling was the main reason behind the "downgrade")
and
- lack of corresponding "quirk" in libata hasn't been problematic so far
so IMO there is no longer a valid reason to punish PIO performance and the said "quirk" should be removed (in 2.6.26 after long time in -mm).
> > so remove quirk code from ide_get_best_pio_mode() > > and IDE_HFLAG_PIO_DOWNGRADE host flag. > > > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
| |