Messages in this thread | | | From | Bartlomiej Zolnierkiewicz <> | Subject | Re: [PATCH 4/5] ide-generic: use ide_find_port() | Date | Tue, 19 Feb 2008 22:20:08 +0100 |
| |
On Tuesday 19 February 2008, Sergei Shtylyov wrote: > Bartlomiej Zolnierkiewicz wrote: > > > There should be no functional changes caused by this patch. > > > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> > > Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com> > > > Index: b/drivers/ide/ide-generic.c > > =================================================================== > > --- a/drivers/ide/ide-generic.c > > +++ b/drivers/ide/ide-generic.c > > @@ -90,18 +90,27 @@ static int __init ide_generic_init(void) > > int i; > > > > for (i = 0; i < MAX_HWIFS; i++) { > > - ide_hwif_t *hwif = &ide_hwifs[i]; > > + ide_hwif_t *hwif; > > unsigned long io_addr = ide_default_io_base(i); > > hw_regs_t hw; > > > > - if (hwif->chipset == ide_unknown && io_addr) { > > - u8 oldnoprobe = hwif->noprobe; > > + if (io_addr) { > > + u8 oldnoprobe; > > + > > + /* > > + * Skip probing if the corresponding > > + * slot entry is already occupied. > > IMHO, it's either "slot" or "entry", else it sounds superfluous. :-)
I made 'take 2' with "entry" removed, thanks.
| |