lkml.org 
[lkml]   [2008]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [patch] checkpatch.pl: revert wrong --file message
Date

> People, who do cleanups - I'm not talking about running lindent here -
> read through the code while they fix it up.

Please feel free to repeat my little experiment: give someone who sends
you a lot of checkpatch.pl only patches a simple task that actually
requires a little actual code change and at least a little localized
understanding of code. See how well they do.

In my case it was the "turn ->ioctl into ->unlocked_ioctl" task,
which was simple enough.

I found that there were a lot of useful unlocked_ioctl patches
in the end, but they all only came from people who hadn't submitted
any checkpatch.pl only patches before.

-Andi





\
 
 \ /
  Last update: 2008-02-18 11:19    [W:0.057 / U:0.948 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site