Messages in this thread | | | Date | Sat, 16 Feb 2008 22:56:37 +0000 | From | Andy Whitcroft <> | Subject | Re: [patch] checkpatch.pl: revert wrong --file message |
| |
On Sat, Feb 16, 2008 at 12:27:33PM +0200, Pekka Enberg wrote: > Hi, > > On Feb 16, 2008 12:18 PM, Thomas Gleixner <tglx@linutronix.de> wrote: > > People, who do cleanups - I'm not talking about running lindent here - > > read through the code while they fix it up. > > > > Actually they find bugs that way or at least come up with useful > > questions about code which is not obvious in the first place. > > > > Discouraging such cleanups with a pretty offensive warning is > > counterproductive. > > Well, it's not just about cleanup patches submitted by "newbies". I > use checkpatch for development too and the warning is real PITA for > that.
The warning is suppressed on -q as its a pain indeed if one is using it to check files and you are not intending a single file cleanup.
Is the concensus the warning is useful, or unhelpful.
-apw
| |