Messages in this thread | | | Date | Sat, 16 Feb 2008 11:31:46 -0800 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH 2/2] kernel/{exit.c, signal.c, power/process.c}: replace !likely(x) by likely(!x) |
| |
Roel Kluin wrote: > H. Peter Anvin wrote: >> Roel Kluin wrote: >>> Not entirely sure who to send this to >>> --- >>> Replace !likely(x) by likely(!x) >> Whoa... >> >> Are you sure this is correct? >> >> !likely(x) is equivalent to unlikely(!x), not the opposite, so this is a >> functional change... >> > You are right, sorry, Need more caffeine. I will send the right patch later.
Note I didn't say it was wrong, I just wanted a bit more explanation about why it's right, if it is.
-hpa
| |