Messages in this thread | | | Date | Sun, 17 Feb 2008 05:16:24 +0100 | From | Rene Herman <> | Subject | Re: [PATCH 2/2] kernel/{exit.c, signal.c, power/process.c}: replace !likely(x) by likely(!x) |
| |
On 17-02-08 04:56, H. Peter Anvin wrote:
> Rene Herman wrote: >> On 16-02-08 20:01, H. Peter Anvin wrote: >>> Roel Kluin wrote: >>>> Not entirely sure who to send this to >>>> --- >>>> Replace !likely(x) by likely(!x) >>> >>> Whoa... >>> >>> Are you sure this is correct? >>> >>> !likely(x) is equivalent to unlikely(!x) >> >> Not with respect to its value I believe? likely(x) == !!(x), and >> unlikely(!x) == !!(!x) = !x, so conditions work out differently? > > You missed one ! sign: > > !likely(x) == !!!(x) == unlikely(!x) == !!(!(x))
Yup, sorry, misread.
Rene.
| |