Messages in this thread | | | Date | Thu, 1 Jan 2009 02:32:32 +0000 | From | Al Viro <> | Subject | Re: [PATCH 2/4] ufs: don't truncate longer ufs2 fast symlinks |
| |
On Wed, Dec 31, 2008 at 04:50:06PM +0000, Duane Griffin wrote: > } else { > - for (i = 0; i < (UFS_NDADDR + UFS_NINDIR) * 4; i++) > + for (i = 0; i < (UFS_NDADDR + UFS_NINDIR) * 4 * 2; i++) > ufsi->i_u1.i_symlink[i] = ufs2_inode->ui_u2.ui_symlink[i];
a) that probably ought to be a memcpy() b) max len is superblock parameter and you've even validated it. Why don't you use it?
> - for (i = 0; i < (UFS_NDADDR + UFS_NINDIR) * 4; i++) > + for (i = 0; i < (UFS_NDADDR + UFS_NINDIR) * 4 * 2; i++) > ufs_inode->ui_u2.ui_symlink[i] = ufsi->i_u1.i_symlink[i];
Ditto.
| |