lkml.org 
[lkml]   [2008]   [Dec]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] ufs: don't truncate longer ufs2 fast symlinks
On Wed, Dec 31, 2008 at 04:50:06PM +0000, Duane Griffin wrote:
> } else {
> - for (i = 0; i < (UFS_NDADDR + UFS_NINDIR) * 4; i++)
> + for (i = 0; i < (UFS_NDADDR + UFS_NINDIR) * 4 * 2; i++)
> ufsi->i_u1.i_symlink[i] = ufs2_inode->ui_u2.ui_symlink[i];

a) that probably ought to be a memcpy()
b) max len is superblock parameter and you've even validated it. Why don't
you use it?

> - for (i = 0; i < (UFS_NDADDR + UFS_NINDIR) * 4; i++)
> + for (i = 0; i < (UFS_NDADDR + UFS_NINDIR) * 4 * 2; i++)
> ufs_inode->ui_u2.ui_symlink[i] = ufsi->i_u1.i_symlink[i];

Ditto.


\
 
 \ /
  Last update: 2009-01-01 13:42    [W:0.051 / U:1.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site