Messages in this thread Patch in this message | | | From | "Duane Griffin" <> | Subject | [PATCH 3/4] ufs: ensure fast symlinks are NUL-terminated | Date | Wed, 31 Dec 2008 16:50:07 +0000 |
| |
Ensure fast symlink targets are NUL-terminated, even if corrupted on-disk.
Signed-off-by: Duane Griffin <duaneg@dghda.com> --- fs/ufs/inode.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/fs/ufs/inode.c b/fs/ufs/inode.c index c1ea916..c2edfb6 100644 --- a/fs/ufs/inode.c +++ b/fs/ufs/inode.c @@ -658,8 +658,9 @@ static int ufs1_read_inode(struct inode *inode, struct ufs_inode *ufs_inode) for (i = 0; i < (UFS_NDADDR + UFS_NINDIR); i++) ufsi->i_u1.i_data[i] = ufs_inode->ui_u2.ui_addr.ui_db[i]; } else { - for (i = 0; i < (UFS_NDADDR + UFS_NINDIR) * 4; i++) + for (i = 0; i < (UFS_NDADDR + UFS_NINDIR) * 4 - 1; i++) ufsi->i_u1.i_symlink[i] = ufs_inode->ui_u2.ui_symlink[i]; + ufsi->i_u1.i_symlink[(UFS_NDADDR + UFS_NINDIR) * 4 - 1] = 0; } return 0; } @@ -708,8 +709,9 @@ static int ufs2_read_inode(struct inode *inode, struct ufs2_inode *ufs2_inode) ufsi->i_u1.u2_i_data[i] = ufs2_inode->ui_u2.ui_addr.ui_db[i]; } else { - for (i = 0; i < (UFS_NDADDR + UFS_NINDIR) * 4 * 2; i++) + for (i = 0; i < (UFS_NDADDR + UFS_NINDIR) * 4 * 2 - 1; i++) ufsi->i_u1.i_symlink[i] = ufs2_inode->ui_u2.ui_symlink[i]; + ufsi->i_u1.i_symlink[(UFS_NDADDR + UFS_NINDIR) * 4 * 2 - 1] = 0; } return 0; } -- 1.6.0.6
| |