Messages in this thread Patch in this message | | | From | Mike Frysinger <> | Subject | [PATCH] headers_check.pl: disallow extern's | Date | Sat, 27 Dec 2008 02:43:36 -0500 |
| |
Since prototypes with "extern" refer to kernel functions, they make no sense in userspace, so reject them automatically.
Signed-off-by: Mike Frysinger <vapier@gentoo.org> --- scripts/headers_check.pl | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/scripts/headers_check.pl b/scripts/headers_check.pl index 488a3b1..15b9bc6 100644 --- a/scripts/headers_check.pl +++ b/scripts/headers_check.pl @@ -33,6 +33,7 @@ foreach my $file (@files) { while ($line = <FH>) { $lineno++; check_include(); + check_prototypes(); } close FH; } @@ -54,3 +55,11 @@ sub check_include } } } + +sub check_prototypes +{ + if ($line =~ m/^\s*extern\b/) { + printf STDERR "$filename:$lineno: extern's make no sense in userspace\n"; + $ret = 1; + } +} -- 1.6.0.6
| |