Messages in this thread | | | Subject | Re: [PATCH] sh: maple: add support for Maple controller as a joystick | From | Harvey Harrison <> | Date | Mon, 22 Dec 2008 17:07:35 -0800 |
| |
On Mon, 2008-12-22 at 15:06 -0800, Andrew Morton wrote: > On Fri, 19 Dec 2008 23:15:42 +0000 > Adrian McMenamin <adrian@newgolddream.dyndns.info> wrote: > > > Not sure what happened with earlier submissions, so here is an up-to-date > > patch for the Dreamcast Maple controlled. > > > > > > Add support for the SEGA Dreamcast Maple controller as a joystick > > > > ... > > > > +static void dc_pad_callback(struct mapleq *mq) > > +{ > > + unsigned short buttons; > > + struct maple_device *mapledev = mq->dev; > > + struct dc_pad *pad = maple_get_drvdata(mapledev); > > + struct input_dev *dev = pad->dev; > > + unsigned char *res = mq->recvbuf; > > + > > + buttons = ~cpu_to_le16(*(unsigned short *)(res + 8)); > > hm, could that be simplified?
And as a bonus fix the obvious sparse warning:
buttons = ~le16_to_cpup((__le16 *)(res + 8));
Cheers,
Harvey
| |