Messages in this thread | | | Date | Sat, 20 Dec 2008 15:16:59 +0000 | From | Matt Fleming <> | Subject | Re: [PATCH] sh: maple: add support for Maple controller as a joystick |
| |
On Fri, Dec 19, 2008 at 11:15:42PM +0000, Adrian McMenamin wrote: > > Add support for the SEGA Dreamcast Maple controller as a joystick >
[snip]
> + struct dc_pad *pad = maple_get_drvdata(mapledev); > + struct input_dev *dev = pad->dev; > + unsigned char *res = mq->recvbuf; > + > + buttons = ~cpu_to_le16(*(unsigned short *)(res + 8)); > +
I may be wrong but shouldn't this use the I/O accessor functions?
> + > + pad = kzalloc(sizeof(struct dc_pad), GFP_KERNEL); > + idev = input_allocate_device(); > + if (!pad || !idev){ > + error = ENOMEM; > + goto fail; > + }
[snip]
> +fail: > + input_free_device(pad->dev);
Possible NULL pointer dereference?
| |