Messages in this thread Patch in this message | | | Date | Sun, 21 Dec 2008 19:08:09 +0100 (CET) | From | Julia Lawall <> | Subject | [PATCH] drivers/mfd: Adjust NULL test |
| |
From: Julia Lawall <julia@diku.dk>
Since ei is already known to be non-NULL, I assume that what was intended was to test the result of kzalloc.
The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/)
// <smpl> @@ expression E,E1; identifier f,fld,fld1; statement S1,S2; @@
E->fld = f(...); ... when != E = E1 when != E->fld1 = E1 if ( - E + E->fld == NULL) S1 else S2 // </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
--- drivers/mfd/htc-egpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff -u -p a/drivers/mfd/htc-egpio.c b/drivers/mfd/htc-egpio.c --- a/drivers/mfd/htc-egpio.c +++ b/drivers/mfd/htc-egpio.c @@ -307,7 +307,7 @@ static int __init egpio_probe(struct pla ei->nchips = pdata->num_chips; ei->chip = kzalloc(sizeof(struct egpio_chip) * ei->nchips, GFP_KERNEL); - if (!ei) { + if (!ei->chip) { ret = -ENOMEM; goto fail; }
| |