Messages in this thread | | | Date | Tue, 16 Dec 2008 10:27:34 +0000 | From | Mark Brown <> | Subject | Re: [PATCH 7/7] regulator: PCF50633 pmic driver |
| |
On Mon, Dec 15, 2008 at 07:34:50PM +0530, Balaji Rao wrote: > On Mon, Dec 15, 2008 at 11:35:49AM +0000, Mark Brown wrote: > > On Sun, Dec 14, 2008 at 04:34:00PM +0530, Balaji Rao wrote:
> > > + .set_suspend_enable = pcf50633_regulator_enable, > > > + .set_suspend_disable = pcf50633_regulator_disable,
> > Are you sure that the suspend variants of the operations should be the > > same as the regular versions?
> Yes, basically the chip doesn't change state during suspend/resume. > We just enable or disable them the usual way.
In that case you shouldn't be providing these variants - they are for configuring alternative settings which can be switched to in hardware when the system suspends. If the regular functions should be used then the code to do this should be in the core since the same thing will be needed for all regulators that don't have the hardware support.
| |