Messages in this thread | | | Date | Mon, 15 Dec 2008 19:34:50 +0530 | From | Balaji Rao <> | Subject | Re: [PATCH 7/7] regulator: PCF50633 pmic driver |
| |
On Mon, Dec 15, 2008 at 11:35:49AM +0000, Mark Brown wrote: > On Sun, Dec 14, 2008 at 04:34:00PM +0530, Balaji Rao wrote: > > > +struct regulator_ops pcf50633_regulator_ops = { > > + .set_voltage = pcf50633_regulator_set_voltage, > > + .get_voltage = pcf50633_regulator_get_voltage, > > + .enable = pcf50633_regulator_enable, > > + .disable = pcf50633_regulator_disable, > > + .is_enabled = pcf50633_regulator_is_enabled, > > + .set_suspend_enable = pcf50633_regulator_enable, > > + .set_suspend_disable = pcf50633_regulator_disable, > > +}; > > Are you sure that the suspend variants of the operations should be the > same as the regular versions? >
Yes, basically the chip doesn't change state during suspend/resume. We just enable or disable them the usual way.
> > +struct platform_driver pcf50633_regulator_driver = { > > + .driver = { > > + .name = "pcf50633-regltr", > > + }, > > + .probe = pcf50633_regulator_probe, > > + .remove = __devexit_p(pcf50633_regulator_remove), > > +}; > > Not that it matters too much but I have a hard time liking "regltr".
Ha! The name pcf50633-regulator exceeds 20 chars and there is no space remaining for the ".0" or ".1" at the end. This gave me a sysfs warning and so I changed it.
- Balaji
| |