Messages in this thread | | | Date | Fri, 21 Nov 2008 16:12:52 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] x86: powernow-k8: ignore out-of-range PstateStatus value |
| |
* Andreas Herrmann <andreas.herrmann3@amd.com> wrote:
> On Fri, Nov 21, 2008 at 09:23:46AM +0100, Ingo Molnar wrote: > > > > nice fix! A few minor nits: > > > > > + /* a workaround for family 11h erratum 311 might cause > > > + an "out-of-range Pstate if the core is in Pstate-0 */ > > > Please use the customary comment style: > > /* > > * Comment ..... > > * ...... goes here: > > */ > > I don't prefer that style -- but if you do.
it's not about my or your preference. It's about what we all do in the kernel, documented in Documentation/CodingStyle:
| The preferred style for long (multi-line) comments is: | | /* | * This is the preferred style for multi-line | * comments in the Linux kernel source code. | * Please use it consistently. | * | * Description: A column of asterisks on the left side, | * with beginning and ending almost-blank lines. | */
Ingo
| |