Messages in this thread | | | Date | Fri, 21 Nov 2008 14:16:09 +0100 | From | Andreas Herrmann <> | Subject | Re: [PATCH] x86: powernow-k8: ignore out-of-range PstateStatus value |
| |
On Fri, Nov 21, 2008 at 09:23:46AM +0100, Ingo Molnar wrote: > > nice fix! A few minor nits: > > > + /* a workaround for family 11h erratum 311 might cause > > + an "out-of-range Pstate if the core is in Pstate-0 */
> Please use the customary comment style: > /* > * Comment ..... > * ...... goes here: > */
I don't prefer that style -- but if you do.
> and since it's multi-line anyway, keep to the 80-col limit too please.
2nd line should be exactly 80 columns.
> > diff --git a/arch/x86/kernel/cpu/cpufreq/powernow-k8.h b/arch/x86/kernel/cpu/cpufreq/powernow-k8.h > > index ab48cfe..4078f5d 100644 > > --- a/arch/x86/kernel/cpu/cpufreq/powernow-k8.h > > +++ b/arch/x86/kernel/cpu/cpufreq/powernow-k8.h > > @@ -23,7 +23,9 @@ struct powernow_k8_data { > > u32 exttype; /* extended interface = 1 */ > > > > /* keep track of the current fid / vid or pstate */ > > - u32 currvid, currfid, currpstate; > > + u32 currvid, currfid; > > + u32 currpstate; > > Any reason why it has been moved to a separate line?
Sure, it's to emphasize that the following define is just for this field.
Andreas
| |