Messages in this thread Patch in this message | | | From | Rusty Russell <> | Date | Sat, 22 Nov 2008 00:20:07 +1030 | Subject | [PATCH 1/3] cpumask: use for_each_online_cpu() in drivers/infiniband/hw/ehca/ehca_irq.c |
| |
Impact: cleanup
In future, accessing cpu numbers beyond nr_cpu_ids (the runtime limit) will be undefined. We can avoid future problems by using for_each_online_cpu() here.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Cc: Hoang-Nam Nguyen <hnguyen@de.ibm.com> Cc: Christoph Raisch <raisch@de.ibm.com> --- drivers/infiniband/hw/ehca/ehca_irq.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
diff -r 38b459d1e9c7 drivers/infiniband/hw/ehca/ehca_irq.c --- a/drivers/infiniband/hw/ehca/ehca_irq.c Fri Nov 07 22:33:08 2008 +1100 +++ b/drivers/infiniband/hw/ehca/ehca_irq.c Fri Nov 07 22:48:13 2008 +1100 @@ -922,10 +922,9 @@ void ehca_destroy_comp_pool(void) unregister_hotcpu_notifier(&comp_pool_callback_nb); - for (i = 0; i < NR_CPUS; i++) { - if (cpu_online(i)) - destroy_comp_task(pool, i); - } + for_each_online_cpu(i) + destroy_comp_task(pool, i); + free_percpu(pool->cpu_comp_tasks); kfree(pool); }
| |