Messages in this thread | | | Date | Wed, 19 Nov 2008 19:38:36 +0100 | From | Pierre Ossman <> | Subject | Re: [patch 5/7] SDHCI: Samsung SDHCI (HSMMC) driver |
| |
On Sun, 16 Nov 2008 00:03:02 +0000 Ben Dooks <ben-linux@fluff.org> wrote:
> On Fri, Nov 14, 2008 at 10:48:13PM +0100, Pierre Ossman wrote: > > On Mon, 03 Nov 2008 20:09:49 +0000 > > Ben Dooks <ben-linux@fluff.org> wrote: > > > + if (pdata->cfg_card) > > > + pdata->cfg_card(ourhost->pdev, host->ioaddr, > > > + ios, host->mmc->card); > > > > What's the deal here? Hosts shouldn't know more about the card than the > > MMC core tells them. > > Depending on exactly which version, there's a number of configurations > in the extra configuration registers that get changed, such as delays > used for clock feedback which are meant to be chnaged when the speed > of the card is changed. Unfortunately this changes depending on the > chip model and possibly also on the board it is on. > > The other is that it is possible that depending on the chip and board > combination things like the GPIO driver-strength controls will need to > be changed.
I don't see where knowledge about the card gets into the picture here. All of this sounds like information that is gathered from platform data and/or ios information.
-- -- Pierre Ossman
Linux kernel, MMC maintainer http://www.kernel.org rdesktop, core developer http://www.rdesktop.org
WARNING: This correspondence is being monitored by the Swedish government. Make sure your server uses encryption for SMTP traffic and consider using PGP for end-to-end encryption.
| |