Messages in this thread | | | Date | Fri, 14 Nov 2008 22:48:13 +0100 | From | Pierre Ossman <> | Subject | Re: [patch 5/7] SDHCI: Samsung SDHCI (HSMMC) driver |
| |
On Mon, 03 Nov 2008 20:09:49 +0000 Ben Dooks <ben-linux@fluff.org> wrote:
> +static void sdhci_s3c_sel_sclk(struct sdhci_host *host) > +{ > + struct sdhci_s3c *ourhost = to_s3c(host); > + > + /* select sclk */ > + u32 tmp = readl(host->ioaddr + 0x80); > + > + if ((tmp & (3 << 4)) == (2 << 4)) > + return; > + > + tmp &= ~(3<<4); > + tmp |= (2 << 4); > + writel(tmp, host->ioaddr + 0x80); > +}
No defines for this? This is not terribly readable.
> + if (pdata->cfg_card) > + pdata->cfg_card(ourhost->pdev, host->ioaddr, > + ios, host->mmc->card);
What's the deal here? Hosts shouldn't know more about the card than the MMC core tells them.
Since I have no hardware for this, could you take it upon you to handle support for these chips? I'd like a MAINTAINERS patch for that as well.
Rgds -- -- Pierre Ossman
Linux kernel, MMC maintainer http://www.kernel.org rdesktop, core developer http://www.rdesktop.org
WARNING: This correspondence is being monitored by the Swedish government. Make sure your server uses encryption for SMTP traffic and consider using PGP for end-to-end encryption.
| |