lkml.org 
[lkml]   [2008]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] ftrace: do not update max buffer with no users

* Steven Rostedt <rostedt@goodmis.org> wrote:

>
> On Wed, 12 Nov 2008, Andrew Morton wrote:
> > This sort of thing:
> >
> > +#ifdef CONFIG_TRACER_MAX_TRACE
> > if (current_trace && current_trace->print_max)
> > iter->tr = &max_tr;
> > else
> > +#endif
> > iter->tr = inode->i_private;
> >
> > is particularly regrettable.
>
> Yeah, I know it is particularly ugly :-(
>
> I was hoping to spend some time to find a way to clean it up. The
> other answer is to just scrap the config all together, and let the
> unused max latency tracer buffer be allocated and take up space
> (with no users).

Correct. That would also result in a smaller patch for .28, right?

Ingo


\
 
 \ /
  Last update: 2008-11-13 09:39    [W:0.043 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site