Messages in this thread | | | Date | Wed, 12 Nov 2008 21:43:02 -0500 (EST) | From | Steven Rostedt <> | Subject | Re: [PATCH 1/1] ftrace: do not update max buffer with no users |
| |
On Wed, 12 Nov 2008, Andrew Morton wrote: > This sort of thing: > > +#ifdef CONFIG_TRACER_MAX_TRACE > if (current_trace && current_trace->print_max) > iter->tr = &max_tr; > else > +#endif > iter->tr = inode->i_private; > > is particularly regrettable.
Yeah, I know it is particularly ugly :-(
I was hoping to spend some time to find a way to clean it up. The other answer is to just scrap the config all together, and let the unused max latency tracer buffer be allocated and take up space (with no users).
-- Steve
| |