Messages in this thread | | | Date | Thu, 13 Nov 2008 09:35:36 +0100 | From | Andi Kleen <> | Subject | Re: [rfc] x86: optimise page fault path a little |
| |
> this flow could be cleaned up further: > > [...] > > + bad_area(regs, error_code, address); > > + return; > [...] > > + bad_area(regs, error_code, address); > > + return; > [...] > > + bad_area(regs, error_code, address); > > + return; > [...] > > + bad_area(regs, error_code, address); > > + return; > > Any reason why that pattern shouldnt be changed to an appropriate goto > bad_area? (probably the same goes for the nosemaphore error paths too)
The tail call is already effectively a goto.
-Andi
-- ak@linux.intel.com
| |