lkml.org 
[lkml]   [2008]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [rfc] x86: optimise page fault path a little
> this flow could be cleaned up further:
>
> [...]
> > + bad_area(regs, error_code, address);
> > + return;
> [...]
> > + bad_area(regs, error_code, address);
> > + return;
> [...]
> > + bad_area(regs, error_code, address);
> > + return;
> [...]
> > + bad_area(regs, error_code, address);
> > + return;
>
> Any reason why that pattern shouldnt be changed to an appropriate goto
> bad_area? (probably the same goes for the nosemaphore error paths too)

The tail call is already effectively a goto.

-Andi

--
ak@linux.intel.com


\
 
 \ /
  Last update: 2008-11-13 09:29    [W:0.053 / U:3.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site