lkml.org 
[lkml]   [2008]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [rfc] x86: optimise page fault path a little

* Nick Piggin <npiggin@suse.de> wrote:

> > 32-bit should use oops_begin() too. Solves the previous comment as
> > well.
> >
> > > +#ifdef CONFIG_X86_32
> > > + die("Oops", regs, error_code);
> > > + bust_spinlocks(0);
> > > + do_exit(SIGKILL);
> > > +#else
> > > + if (__die("Oops", regs, error_code))
> > > + regs = NULL;
> > > + /* Executive summary in case the body of the oops scrolled away */
> > > + printk(KERN_EMERG "CR2: %016lx\n", address);
> > > + oops_end(flags, regs, SIGKILL);
> > > +#endif
> >
> > this difference seems unnecessary too - 32-bit should use oops_end()
> > too.
>
> Probably all 3 good comments, but I didn't want to be tempted into
> changing behaviour (modulo adding bugs). Easy to merge them up in a
> subsequent patch, however...

please do feel tempted to clean this code up - and if it changes
behavior, split it up into smaller steps. The patch is already quite
large with a flux of 430 lines:

1 file changed, 251 insertions(+), 188 deletions(-)

... your primary goal is faster code, we also want cleaner code. I
think we can meet in the middle, have faster _and_ cleaner code, and
it's a done deal ;)

Ingo


\
 
 \ /
  Last update: 2008-11-13 17:09    [W:0.067 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site