Messages in this thread | | | Date | Thu, 13 Nov 2008 23:05:03 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] sparse_irq aka dyn_irq v13 |
| |
* Yinghai Lu <yinghai@kernel.org> wrote:
> >> + /* > >> + * We have to do the hash-walk again, to avoid races > >> + * with another CPU: > >> + */ > >> + list_for_each_entry(desc, hash_head, hash_entry) > >> + if (desc->irq == irq) > >> + goto out_unlock;
should be:
> >> + list_for_each_entry(desc, hash_head, hash_entry) { > >> + if (desc->irq == irq) > >> + goto out_unlock; > >> + }
and:
> >> + desc = kzalloc_node(sizeof(*desc), GFP_KERNEL, node); > > > > Oh for gawd's sake. PLEASE read Documentation/SubmitChecklist. > > Carefully. We've already discussed this. > > > > You cannot do a GFP_KERNEL allocation under spin_lock_irqsave().
yes.
Ingo
| |