lkml.org 
[lkml]   [2008]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] sparse_irq aka dyn_irq v13

* Yinghai Lu <yinghai@kernel.org> wrote:


> >> + /*
> >> + * We have to do the hash-walk again, to avoid races
> >> + * with another CPU:
> >> + */
> >> + list_for_each_entry(desc, hash_head, hash_entry)
> >> + if (desc->irq == irq)
> >> + goto out_unlock;

should be:

> >> + list_for_each_entry(desc, hash_head, hash_entry) {
> >> + if (desc->irq == irq)
> >> + goto out_unlock;
> >> + }

and:

> >> + desc = kzalloc_node(sizeof(*desc), GFP_KERNEL, node);
> >
> > Oh for gawd's sake. PLEASE read Documentation/SubmitChecklist.
> > Carefully. We've already discussed this.
> >
> > You cannot do a GFP_KERNEL allocation under spin_lock_irqsave().

yes.

Ingo


\
 
 \ /
  Last update: 2008-11-13 23:09    [W:0.157 / U:1.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site