Messages in this thread | | | Date | Sun, 16 Nov 2008 17:51:29 -0800 | From | Mike Travis <> | Subject | Re: [PATCH] sparse_irq aka dyn_irq v13 |
| |
H. Peter Anvin wrote: > Yinghai Lu wrote: >> 2. make irq number is bus/devfn/idx, and every dev func will use 12bit range, irq number is relatively fixed not like current MSI irq creating is some kind of floating from NR_IRQS too. > > 2 is *STILL WRONG*, dammit! > > You keep bringing this one up, but our PCI addressing is > *DOMAIN*/bus/devfn -- it falls flat on its face when you have more than > 16 PCI domains. CAN WE PLEASE STOP WITH THIS FOOLISHNESS NOW! > > -hpa
Hmm, I was going to bring this up as well... ;-)
X was changed quite a while ago to domain/bus/dev/func, which was a lot easier to deal with than trying to "offset" the bus with domain * some large number + bus. Currently max nodes is 512 so it deserves it's own field. ;-)
Btw, are you suggesting combining device and function? That might be inadvertently squeezing something that shouldn't be.
Thanks, Mike
| |