Messages in this thread | | | Date | Thu, 13 Nov 2008 20:14:16 +0200 | From | Felipe Balbi <> | Subject | Re: [PATCH] led: simplify led_trigger_register_simple |
| |
On Thu, Nov 13, 2008 at 12:38:32PM +0000, Richard Purdie wrote: > The simple triggers were designed to cause minimum interference to the > usually external subsystem code they were added into. As an example this > meant things like errors were just handled gracefully with a printk > warning and did not take down the whole subsystem. I therefore don't > regard this patch as a simplification, more a complication.
That's a matter of changing the return ERR_PTR(err); back to a printk.
-- balbi
| |