Messages in this thread | | | Date | Thu, 13 Nov 2008 15:03:12 +0300 | From | Anton Vorontsov <> | Subject | Re: [PATCH] led: simplify led_trigger_register_simple |
| |
On Thu, Nov 13, 2008 at 05:09:13AM +0200, Felipe Balbi wrote: > From: Felipe Balbi <felipe.balbi@nokia.com> > > We can make led_trigger_register_simple by returning a > struct led_trigger *, instead of passing a struct led_trigger ** > as a parameter and changing it inside the function. > > Cc: Anton Vorontsov <cbou@mail.ru> > Cc: David Woodhouse <dwmw2@infradead.org> > Cc: Greg KH <greg@kroah.com> > Cc: Pierre Ossman <drzeus@drzeus.cx> > Cc: Richard Purdie <rpurdie@linux.intel.com> > Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com> > --- > Note that I could only test ide, power_supply and mmc changes with my laptop. > The other changes weren't tested. > > drivers/leds/led-triggers.c | 25 ++++++++++++++--------- > drivers/leds/ledtrig-ide-disk.c | 6 ++++- > drivers/mmc/core/host.c | 4 ++- > drivers/mtd/nand/nand_base.c | 5 +++- > drivers/power/power_supply_leds.c | 36 ++++++++++++++++++++++++++++------
For power supply bits:
Acked-by: Anton Vorontsov <cbouatmailru@gmail.com>
Thanks.
| |