Messages in this thread Patch in this message | | | From | Mark Brown <> | Subject | [PATCH] leds: Fix locking for WM8350 | Date | Thu, 13 Nov 2008 14:57:49 +0000 |
| |
LED API functions aren't allowed to sleep so we can't take a lock when setting the brightness of the LED.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> ---
Sorry, I managed to drop this fix when moving the driver over to mainline for submission. I'll roll it into the original patch in any future submissions.
drivers/leds/leds-wm8350.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/leds/leds-wm8350.c b/drivers/leds/leds-wm8350.c index f3e5af3..283625c 100644 --- a/drivers/leds/leds-wm8350.c +++ b/drivers/leds/leds-wm8350.c @@ -170,10 +170,7 @@ static void wm8350_led_set(struct led_classdev *led_cdev, { struct wm8350_led *led = to_wm8350_led(led_cdev); - mutex_lock(&led->mutex); led->value = value; - mutex_unlock(&led->mutex); - schedule_work(&led->work); } -- 1.5.6.5
| |