Messages in this thread | | | Date | Sat, 15 Nov 2008 19:51:20 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH] leds: Fix locking for WM8350 |
| |
On Sat 2008-11-15 17:50:50, Mark Brown wrote: > On Sat, Nov 15, 2008 at 06:31:10PM +0100, Pavel Machek wrote: > > > Unfortunately, now you write to value w/o locking -> races > > possible. Maybe you need to make value atomic_t? > > Yes, that'd be safer though I'd be surprised to see systems that could > trigger it.
Yes, they are uncommon. They exist; SPARC, IIRC. Plus you need barriers on anything SMP... Just use atomic_t. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |