lkml.org 
[lkml]   [2008]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH linux-next] : Tree for November 12 (libcrc32c)
On Wed, Nov 12, 2008 at 01:01:05PM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> libcrc32c uses CRYPTO interfaces so it should depend on CRYPTO.
>
> crypto/built-in.o: In function `crc32c_mod_init':
> crc32c.c:(.init.text+0xc): undefined reference to `crypto_register_shash'
> crypto/built-in.o: In function `crc32c_mod_fini':
> crc32c.c:(.exit.text+0xc): undefined reference to `crypto_unregister_shash'
> lib/built-in.o: In function `crc32c':
> (.text+0xfcf9): undefined reference to `crypto_shash_update'
> lib/built-in.o: In function `libcrc32c_mod_init':
> libcrc32c.c:(.init.text+0x666): undefined reference to `crypto_alloc_shash'
> lib/built-in.o: In function `libcrc32c_mod_fini':
> libcrc32c.c:(.exit.text+0xc): undefined reference to `crypto_free_tfm'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>

Thanks, I've fixed it as follows:

commit d9cc217c79df50f9a9f7937aeaa54d89ae198686
Author: Herbert Xu <herbert@gondor.apana.org.au>
Date: Thu Nov 13 22:05:13 2008 +0800

libcrc32c: Select CRYPTO in Kconfig

Selecting CRYPTO_CRC32C is not enough as CRYPTO which CRYPTO_CRC32C
depends on may be disabled. This patch adds the select on CRYPTO.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/lib/Kconfig b/lib/Kconfig
index d09edb7..963009a 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -64,6 +64,7 @@ config CRC7

config LIBCRC32C
tristate "CRC32c (Castagnoli, et al) Cyclic Redundancy-Check"
+ select CRYPTO
select CRYPTO_CRC32C
help
This option is provided for the case where no in-kernel-tree
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

\
 
 \ /
  Last update: 2008-11-13 15:13    [W:0.412 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site