lkml.org 
[lkml]   [2008]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] mac80211: add explicit padding in struct ieee80211_tx_info
From
Date
On Wed, 2008-11-12 at 10:05 -0500, John W. Linville wrote:
> Otherwise, the BUILD_BUG_ON calls in ieee80211_tx_info_clear_status can
> fail on some architectures.
>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
> ---
> Why do we have those BUILD_BUG_ON calls anyway? Hmmm...

Because we actually use those offsets in places to clear things.

> include/net/mac80211.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/include/net/mac80211.h b/include/net/mac80211.h
> index feb52cc..38302d6 100644
> --- a/include/net/mac80211.h
> +++ b/include/net/mac80211.h
> @@ -333,6 +333,7 @@ struct ieee80211_tx_info {
> u8 antenna_sel_tx;
>
> /* 2 byte hole */
> + u8 pad[2];
>
> union {
> struct {
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2008-11-12 18:11    [W:0.048 / U:0.876 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site