Messages in this thread | | | Date | Thu, 13 Nov 2008 22:43:50 +0900 (JST) | Subject | Re: [PATCH] mtd: unify mtd partition/device registration | From | Atsushi Nemoto <> |
| |
On Wed, 12 Nov 2008 18:38:53 -0500, Mike Frysinger <vapier@gentoo.org> wrote: > Rather than having every map/mtd driver doing the same sequence of > registering partitions and/or devices, implement common parse_mtd(). > > Signed-off-by: Mike Frysinger <vapier@gentoo.org> > --- > drivers/mtd/mtdcore.c | 37 +++++++++++++++++++++++++++++++++++++ > include/linux/mtd/mtd.h | 3 +++ > 2 files changed, 40 insertions(+), 0 deletions(-)
I like this idea.
> +int parse_mtd(struct mtd_info *mtd, const char **probe_types, > + struct mtd_partition *parts, int nr_parts) > +{ > +#ifdef CONFIG_MTD_PARTITIONS > + const char *default_part_probe_types[] = { > + "cmdlinepart", > + "RedBoot", > + NULL > + };
But I'm not sure this default_part_probe_types is appropriate.
How about enclose each parser with #ifdefs?
const char *default_part_probe_types[] = { #ifdef CONFIG_MTD_CMDLINE_PARTS "cmdlinepart", #endif #ifdef CONFIG_MTD_REDBOOT_PARTS "RedBoot", #endif NULL };
This get rid of "RedBoot partition parsing not available" noise in boot message when you use default_part_probe_types without MTD_REDBOOT_PARTS.
--- Atsushi Nemoto
| |