Messages in this thread | | | Date | Fri, 14 Nov 2008 00:51:32 +0900 (JST) | Subject | Re: [PATCH] mtd: unify mtd partition/device registration | From | Atsushi Nemoto <> |
| |
On Thu, 13 Nov 2008 09:51:01 -0500, "Mike Frysinger" <vapier.adi@gmail.com> wrote: > > Automatic fallback to mtd_device in parse_mtd() is convenient but > > somewhat unflexible... > > we could just have it do it all the time. i dont see a problem with > exposing the entire block device the whole time ? i know for the > driver or two of mine, i'm fine with it. > > ... > ret = parse_mtd_partitions(mtd, probe_types, &parts, 0); > if (ret > 0) { > ret = add_mtd_partitions(mtd, parts, ret); > kfree(parts); > } else if (nr_parts) > ret = add_mtd_partitions(mtd, parts, nr_parts); > if (ret) > return ret; > #endif > > return add_mtd_device(mtd);
I'm OK with this. But not sure all current mtd partition users.
Are you going to convert all parse_mtd_partitions() call? Maybe some people do not want to change /dev/mtd numbers...
--- Atsushi Nemoto
| |