lkml.org 
[lkml]   [2008]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/4] add ksm kernel shared memory driver
From
Date
On Tue, 2008-11-11 at 17:40 -0500, Valdis.Kletnieks@vt.edu wrote: 
> On Tue, 11 Nov 2008 15:03:45 MST, Jonathan Corbet said:
> Seems reasonably sane to me - only doing the first 128 bytes rather than
> a full 4K page is some 32 times faster. Yes, you'll have the *occasional*
> case where two pages were identical for 128 bytes but then differed, which is
> why there's buckets. But the vast majority of the time, at least one bit
> will be different in the first part.

In the same spirit, computing a CRC32 instead of a SHA1 would probably
be faster as well (faster to compute, and faster to compare the
digests). The increased rate of collision should be negligible.

Also, the upcoming SSE4.2 (Core i7) has a CRC32 instruction. (Support is
already in the kernel: arch/x86/crypto/crc32c-intel.c)



\
 
 \ /
  Last update: 2008-11-13 07:17    [W:0.153 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site