| Date | Wed, 12 Nov 2008 00:43:27 +0200 | From | Avi Kivity <> | Subject | Re: [PATCH 3/4] add ksm kernel shared memory driver |
| |
Jonathan Corbet wrote: >> +static struct list_head slots; >> > > Some of these file-static variable names seem a little..terse... >
While ksm was written to be independent of a certain TLA-named kernel subsystem developed two rooms away, they share some naming... this refers to kvm 'memory slots' which correspond to DIMM banks.
I guess it should be renamed to merge_ranges or something.
-- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.
|