Messages in this thread Patch in this message | | | Date | Thu, 9 Oct 2008 17:22:04 -0700 | From | Venki Pallipadi <> | Subject | [PATCH] Typo in x86 apic.c with DIVISOR setup |
| |
Fix a typo in x86 apic.c CONFG_X86_64 -> CONFIG_X86_64. The intention looks like was to have divisor of 1 on x86_64 kernel.
Also, for DIVISOR value of 1 to work, APIC_TDR_DIV should also change depending on divide by 1 or divide by 16 is used.
Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
--- arch/x86/kernel/apic.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
Index: tip/arch/x86/kernel/apic.c =================================================================== --- tip.orig/arch/x86/kernel/apic.c 2008-10-09 17:12:39.000000000 -0700 +++ tip/arch/x86/kernel/apic.c 2008-10-09 17:13:29.000000000 -0700 @@ -332,10 +332,12 @@ int lapic_get_maxlvt(void) */ /* Clock divisor */ -#ifdef CONFG_X86_64 +#ifdef CONFIG_X86_64 #define APIC_DIVISOR 1 +#define APIC_TDR_DIV APIC_TDR_DIV_1 #else #define APIC_DIVISOR 16 +#define APIC_TDR_DIV APIC_TDR_DIV_16 #endif /* @@ -369,7 +371,7 @@ static void __setup_APIC_LVTT(unsigned i tmp_value = apic_read(APIC_TDCR); apic_write(APIC_TDCR, (tmp_value & ~(APIC_TDR_DIV_1 | APIC_TDR_DIV_TMBASE)) | - APIC_TDR_DIV_16); + APIC_TDR_DIV); if (!oneshot) apic_write(APIC_TMICT, clocks / APIC_DIVISOR);
| |