Messages in this thread Patch in this message | | | Date | Mon, 27 Oct 2008 09:30:57 +0100 (MET) | From | Mikael Pettersson <> | Subject | [PATCH 2.6.28-rc2] x86_64: remove duplicated register setup code in ia32 signal delivery |
| |
ia32_setup_rt_frame() has a duplicated code block labelled "Make -mregparm=3 work" for setting up the register parameters to the user-mode signal handler.
This is harmless but ugly. Remove the redundant assignments.
Signed-off-by: Mikael Pettersson <mikpe@it.uu.se> --- arch/x86/ia32/ia32_signal.c | 5 ----- 1 file changed, 5 deletions(-)
diff -rupN linux-2.6.28-rc2/arch/x86/ia32/ia32_signal.c linux-2.6.28-rc2.x86-signals-fixes/arch/x86/ia32/ia32_signal.c --- linux-2.6.28-rc2/arch/x86/ia32/ia32_signal.c 2008-10-26 21:35:33.000000000 +0100 +++ linux-2.6.28-rc2.x86-signals-fixes/arch/x86/ia32/ia32_signal.c 2008-10-27 08:14:43.000000000 +0100 @@ -572,11 +572,6 @@ int ia32_setup_rt_frame(int sig, struct regs->dx = (unsigned long) &frame->info; regs->cx = (unsigned long) &frame->uc; - /* Make -mregparm=3 work */ - regs->ax = sig; - regs->dx = (unsigned long) &frame->info; - regs->cx = (unsigned long) &frame->uc; - loadsegment(ds, __USER32_DS); loadsegment(es, __USER32_DS);
| |