Messages in this thread Patch in this message | | | Date | Mon, 27 Oct 2008 23:26:00 +0100 (CET) | From | Stefan Richter <> | Subject | [patch 2.6.27.y 1/6] firewire: fix setting tag and sy in iso transmission |
| |
Date: Fri, 12 Sep 2008 18:09:55 +0200 (CEST) From: Stefan Richter <stefanr@s5r6.in-berlin.de>
Reported by Jay Fenlason: The iso packet control accessors in fw-cdev.c had bogus masks.
Same as commit 7a1003449c693f0d57443c8786bbf19717921ae0.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> --- drivers/firewire/fw-cdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Index: linux/drivers/firewire/fw-cdev.c =================================================================== --- linux.orig/drivers/firewire/fw-cdev.c +++ linux/drivers/firewire/fw-cdev.c @@ -720,8 +720,8 @@ static int ioctl_create_iso_context(stru #define GET_PAYLOAD_LENGTH(v) ((v) & 0xffff) #define GET_INTERRUPT(v) (((v) >> 16) & 0x01) #define GET_SKIP(v) (((v) >> 17) & 0x01) -#define GET_TAG(v) (((v) >> 18) & 0x02) -#define GET_SY(v) (((v) >> 20) & 0x04) +#define GET_TAG(v) (((v) >> 18) & 0x03) +#define GET_SY(v) (((v) >> 20) & 0x0f) #define GET_HEADER_LENGTH(v) (((v) >> 24) & 0xff) static int ioctl_queue_iso(struct client *client, void *buffer) -- Stefan Richter -=====-==--- =-=- ==-== http://arcgraph.de/sr/
| |